search

kubernetes-sigs / external-dns

Configure external DNS servers (AWS Route53, Google CloudDNS and others) for Kubernetes Ingresses and Services
Apache License 2.0
7.59k stars 2.54k forks source link

Hetzner causing rate limit error and not handling it correctly #2569

Closed yelhouti closed 2 years ago

yelhouti commented 2 years ago

What happened: Hetzner not creating records due to rate limit error, and not handle it correctly (ie: slowing down).

What you expected to happen: to detect rate limit and slow down, although the detection should be handled by: https://git.blindage.org/21h/hcloud-dns/src/commit/d31cdce4149f7248e6d08adec2ca5a81ff150ce5/zones.go#L92 which doesn't check the response status code and unmarshales to the wrong type, creating the illusion of no error.

Use CreateRecordBulk and UpdateRecordBulk to avoid reaching the limit at the first place.

How to reproduce it (as minimally and precisely as possible): just use hetzner with a cluster with many ingresses.

Environment:

Berndinox commented 2 years ago

Workaround:

Edit: /run/systemd/resolve/resolv.conf Remove IPv6 Resolver.

Raffo commented 2 years ago

Please note that we removed the Hetzner provider due to a DOS attack from the library provider. See #2660 for future follow ups.

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot commented 2 years ago

@k8s-triage-robot: Closing this issue.

In response to [this](https://github.com/kubernetes-sigs/external-dns/issues/2569#issuecomment-1229162573): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues and PRs according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue or PR with `/reopen` >- Mark this issue or PR as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.