search

kubernetes-sigs / external-dns

Configure external DNS servers (AWS Route53, Google CloudDNS and others) for Kubernetes Ingresses and Services
Apache License 2.0
7.71k stars 2.57k forks source link

AWS Route53 provider doesn't appear to obey domain exclusion filters when loading Zones #3718

Open willhughes-au opened 1 year ago

willhughes-au commented 1 year ago

What happened:

I have an AWS Account with two Route53 zones:

When I run external-dns with --domain-filter=example.com it also picks up the zone subdomain.example.com, and I can see the following output from external-dns:

Applying provider record filter for domains: [example.com. .example.com. subdomain.example.com. .subdomain.example.com.]

When I then pass in --exclude-domains=subdomain.example.com, I get the same output.

What you expected to happen:

I expect that --exclude-domains (and the other filtering options as documented) would apply to the Zones method, and those Zones should not be returned.

How to reproduce it (as minimally and precisely as possible):

Have an AWS Account with at least two Route53 zones, with one zone being a subdomain of another.

Anything else we need to know?:

Environment:

rkferreira commented 1 year ago

Hi,

I'm running 0.13.1 and its working fine.

Helm chart expects it as "extraArgs":

extraArgs:
  - --exclude-domains=xxx
  - --exclude-domains=xxx
willhughes-au commented 1 year ago

Yeah, I am providing it as extraArgs in the chart.

I can see the arguments being passed to the pod. That's not the issue.

It's definitely ignoring it for me on 0.13.5.

joaocc commented 1 year ago

Could this be a manifestation of https://github.com/kubernetes-sigs/external-dns/issues/3753 and https://github.com/kubernetes-sigs/external-dns/issues/3948?

k8s-triage-robot commented 9 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

joaocc commented 9 months ago

/remove-lifecycle stale

k8s-triage-robot commented 6 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

joaocc commented 6 months ago

/remove-lifecycle stale

k8s-triage-robot commented 3 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

joaocc commented 3 months ago

/remove-lifecycle stale

k8s-triage-robot commented 1 week ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

joaocc commented 1 week ago

/remove-lifecycle stale