Open iul1an opened 6 months ago
Hey @iul1an , if there are no objections I can help too :)
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle stale
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
/remove-lifecycle stale
What would you like to be added: I would like for the AWS assume role
ExternalID
to not show up in logs, for example:Why is this needed: Even if
ExternalID
is not a password, it's still an exploitable piece of information, and it's printed in the logs, regardless of theloglevel
.Other information If there are no objections, I can work on patching this :) The relevant code that needs to be changed is:
To adjust the message about assuming the AWS role: https://github.com/kubernetes-sigs/external-dns/blob/6ca3e40d1e5e5d752dedcc9e42f014e5292777da/provider/aws/session.go#L60-L70
To hide the field when the whole config is printed, by setting the
secure
tag: https://github.com/kubernetes-sigs/external-dns/blob/6ca3e40d1e5e5d752dedcc9e42f014e5292777da/pkg/apis/externaldns/types.go#L87