search

kubernetes-sigs / external-dns

Configure external DNS servers (AWS Route53, Google CloudDNS and others) for Kubernetes Ingresses and Services
Apache License 2.0
7.76k stars 2.58k forks source link

fix: internal ipv6 being used as external #4808

Open TroyKomodo opened 1 month ago

TroyKomodo commented 1 month ago

Description

This change undoes a check for internal IPv6 addresses to be used when External IP has been requested.

Closes #4807

Checklist

linux-foundation-easycla[bot] commented 1 month ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 1 month ago

Welcome @TroyKomodo!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 1 month ago

Hi @TroyKomodo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign szuecs for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/external-dns/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mloiseleur commented 1 month ago

@TroyKomodo This subject has already been discussed see https://github.com/kubernetes-sigs/external-dns/pull/4574#issuecomment-2286040002:

We are discussing external-dns change in https://kubernetes.slack.com/archives/C771MKDKQ/p1723531094274339 and the InternalIP/ExternalIP topic was discussed in https://kubernetes.slack.com/archives/C09QYUH5W/p1723197933110369 . sig-network tech-leads said that node InternalIP/ExternalIP has no real meaning and different cloud providers might use it differently.

FTM, we concluded it should be provider specific. Wdyt ? Does it makes sense to you ? Do you think you can rework this PR accordingly ?

TroyKomodo commented 1 month ago

I think it doesn't make sense to force everyone to use a specific bug-fix related to AWS not assigning Node IPs correctly. If anything the default behaviour should likely be to not include the Internal IPv6 addresses as external at all unless an annotation is specified. I also think its a fringe use case in AWS since typically there you would make use of the ELBs rather than expose a port on a host.

I think, at a minimum it should check if the IPv6 address is even routable (not in a restricted range) before attempting to use it as an external address. However IMO the best approach is to not include Internal IPv6 addresses in the external addresses unless an annotation is specified to do so.

Am willing to rework the PR to be whatever is decided the best approach is.

TroyKomodo commented 1 month ago

@mloiseleur any updates here?