Request for information/support on http2 transport enablement in conformance test

kubernetes-sigs / gateway-api

Repository for the next iteration of composite service (e.g. Ingress) and load balancing APIs.

https://gateway-api.sigs.k8s.io

Apache License 2.0

1.78k stars 461 forks source link

Request for information/support on http2 transport enablement in conformance test #1982

Open pramodrj07 opened 1 year ago

pramodrj07 commented 1 year ago

What would you like to be added: Need support for http2 in conformance test specifically the "roundtripper" package

Why this is needed: To overcome limitation of just using http1 in the conformance test as the upstream backend host might just support only http2 https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/utils/roundtripper/roundtripper.go#L111

Additional Details : From the initial investigation, it looks like we cannot pass the custom HTTP client into the default round tripper implementation. If there is an alternate way to achieve this, I would like to be redirected there.

gauravkghildiyal commented 1 year ago

Will passing in an http2.Transport through the CustomDialer in a Request be sufficient for your use case?

https://github.com/kubernetes-sigs/gateway-api/blob/6efcfdf8aff7aa7c3ed8deb956e5b93eed779234/conformance/utils/roundtripper/roundtripper.go#L41-L52

ibilalkayy commented 1 year ago

Checkout this PR that I just sent

shaneutt commented 1 year ago

This sounds good.

/triage accepted

It would be nice to have this for GA, but it doesn't appear to need to block it so we'll leave it off the v1.0.0 milestone.

k8s-triage-robot commented 3 months ago

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

Confirm that this issue is still relevant with /triage accepted (org members only)
Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

k8s-triage-robot commented 4 days ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue as fresh with /remove-lifecycle stale
Close this issue with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale