Open sunjayBhatia opened 1 year ago
Sounds like a reasonable improvement.
/triage accepted
Given that this is about TLSRoute
, it seems like something we can do after our GA release.
/priority backlog
This issue has not been updated in over 1 year, and should be re-triaged.
You can:
/triage accepted
(org members only)/close
For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/
/remove-triage accepted
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the issue is closedYou can:
/remove-lifecycle stale
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
What would you like to be added:
As a follow up to https://github.com/kubernetes-sigs/gateway-api/pull/2076, we should add test coverage to the TLSRoute test in that PR that makes an assertion on what a client sees when making a connection/request that match a Gateway/TLSRoute with no valid backends (due to invalid ReferenceGrant etc.)
Before we add a test, the language here likely needs a little more specificity (and we should make sure to write tests that match the new language), particularly what "reject" means: https://github.com/kubernetes-sigs/gateway-api/blob/a5ede12430c31639349ae6c00666890591f72a40/apis/v1alpha2/tlsroute_types.go#L104-L108
"Reject" could mean:
Why this is needed:
Full coverage of TLSRoute API surface.
Related to https://github.com/kubernetes-sigs/gateway-api/issues/1579
We can probably do something similar for TCPRoute