kubernetes-sigs / gateway-api

Repository for the next iteration of composite service (e.g. Ingress) and load balancing APIs.
https://gateway-api.sigs.k8s.io
Apache License 2.0
1.84k stars 480 forks source link

conformance: Coverage for request routing to TLSRoute with no valid BackendRefs #2153

Open sunjayBhatia opened 1 year ago

sunjayBhatia commented 1 year ago

What would you like to be added:

As a follow up to https://github.com/kubernetes-sigs/gateway-api/pull/2076, we should add test coverage to the TLSRoute test in that PR that makes an assertion on what a client sees when making a connection/request that match a Gateway/TLSRoute with no valid backends (due to invalid ReferenceGrant etc.)

Before we add a test, the language here likely needs a little more specificity (and we should make sure to write tests that match the new language), particularly what "reject" means: https://github.com/kubernetes-sigs/gateway-api/blob/a5ede12430c31639349ae6c00666890591f72a40/apis/v1alpha2/tlsroute_types.go#L104-L108

"Reject" could mean:

Why this is needed:

Full coverage of TLSRoute API surface.

Related to https://github.com/kubernetes-sigs/gateway-api/issues/1579

We can probably do something similar for TCPRoute

shaneutt commented 1 year ago

Sounds like a reasonable improvement.

/triage accepted

Given that this is about TLSRoute, it seems like something we can do after our GA release.

/priority backlog

k8s-triage-robot commented 3 months ago

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

k8s-triage-robot commented 2 days ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale