search

kubernetes-sigs / gateway-api

Repository for the next iteration of composite service (e.g. Ingress) and load balancing APIs.
https://gateway-api.sigs.k8s.io
Apache License 2.0
1.85k stars 480 forks source link

GEP: HTTPRoute support match by RegularExpression #2694

Open rokkiter opened 10 months ago

rokkiter commented 10 months ago

What would you like to be added:

In gep-726,. it is mentioned that Regula......dsarExpression will be added to HttpRouter as a Future Extension. Hope to promote the implementation of RegularExpression.

Why this is needed: I think RegularExpression is a function with a very wide range of usage scenarios. If route matching cannot be supported natively, we need to implement it in a very complicated way. For example, in istio, the redirect function cannot support regex matching. I can only use envoyfilter to achieve. Because the Gateway API is a standard, if the Gateway API does not support RegularExpression, the istio community's support for regex matching will also be affected. I believe other communities have similar problems.

Istio issue: https://github.com/istio/istio/issues/47500 for support RegularExpression.

arkodg commented 10 months ago

looks like a dup of https://github.com/kubernetes-sigs/gateway-api/issues/2177, @rokkiter you would also need to update the GEP before adding in the API changes

rokkiter commented 10 months ago

Yes, our purpose is similar, I am going to create a new gep to drive this

youngnick commented 10 months ago

Because doing regex path rewrites involves doing a regex path match, followed by using captured info in a rewrite filter, I think that #2177 covers just adding the match criteria as well. See my comment on that for more thoughts on what the resulting GEP will need to address.

k8s-triage-robot commented 7 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 6 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 5 months ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 5 months ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/gateway-api/issues/2694#issuecomment-2144374949): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-triage-robot commented 2 days ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale