search

kubernetes-sigs / gateway-api

Repository for the next iteration of composite service (e.g. Ingress) and load balancing APIs.
https://gateway-api.sigs.k8s.io
Apache License 2.0
1.77k stars 460 forks source link

Dependabot no longer working well for go dependencies #2780

Open robscott opened 7 months ago

robscott commented 7 months ago

What happened: PRs opened by dependabot do not appear to be running go mod tidy and are failing our presubmits.

What you expected to happen: PR opened by dependabot to pass our presubmits.

Anything else we need to know?: Not sure what the solution is here, maybe it's just better dependabot config, or maybe we should look into an alternative like renovate that appears to have a few more configuration options here. With that said, I can't find any prior art for running renovate with k8s projects, so it's probably safest to stick with dependabot if we can get it to work.

jongwooo commented 7 months ago

Can I work on this issue? I think adding few settings to the dependabot.yml might fix it.

jongwooo commented 7 months ago

Currently, the dependabot.yml is only tracking for the directory /. I think adding few settings for the directories(where go.mod is located) gwctl/ and conformance/echo-basic/ might fix this. Ref: https://github.com/stackrox/stackrox/blob/master/.github/dependabot.yaml#L40-L156

youngnick commented 7 months ago

/assign @jongwooo

Sounds great, feel free to make a PR!

jongwooo commented 7 months ago

Still same problem in #2789

robscott commented 7 months ago

Still same problem in #2789

😢 reopening this for now, though #2786 was still very helpful for other reasons. Open to other potential fixes for this particular problem.

sunjayBhatia commented 7 months ago

the issue looks like it is due to there being multiple modules in the repo and the update order in the case of #2789 between the different modules, the gwctl module on the PR branch has an older version of the k8s.io deps than the PR is updating the main module to

sunjayBhatia commented 7 months ago

I don't have the right permissions but looks like a dependabot rebase should fix the issue at hand in https://github.com/kubernetes-sigs/gateway-api/pull/2789

dprotaso commented 7 months ago

I wonder if dropping the replace block in gwctl's go.mod would help. That replace block also prevents people from installing it with go install.

I wonder if this is those niche scenarios were commiting a go.work file makes sense

robscott commented 6 months ago

Unfortunately still failing in #2882

robscott commented 4 months ago

/help

k8s-ci-robot commented 4 months ago

@robscott: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes-sigs/gateway-api/issues/2780): >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.