search

kubernetes-sigs / gateway-api

Repository for the next iteration of composite service (e.g. Ingress) and load balancing APIs.
https://gateway-api.sigs.k8s.io
Apache License 2.0
1.75k stars 454 forks source link

Add conformance test for GRPCRouteFilterRequestHeaderModifier #2900

Open pleshakov opened 5 months ago

pleshakov commented 5 months ago

What would you like to be added: A conformance test for https://github.com/kubernetes-sigs/gateway-api/blob/729d38f9bf17ff72d17f0148452416551296f67c/apis/v1alpha2/grpcroute_types.go#L436

Why this is needed:

Increase conformance feature coverage of GRPCRoute

yashvardhan-kukreja commented 5 months ago

Hi @pleshakov I would love to contribute this.

yashvardhan-kukreja commented 5 months ago

/assign

yashvardhan-kukreja commented 5 months ago

@pleshakov IIUC, isn't this test already achieving what this issue expects? - https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/tests/httproute-request-header-modifier.go

pleshakov commented 5 months ago

Hi @yashvardhan-kukreja

Hi @pleshakov I would love to contribute this.

that's great! I'd recommend to wait until any of the maintainers replied that this issue makes sense or ask this question in the gateway api slack channel https://gateway-api.sigs.k8s.io/contributing/#communications , to double check this work is needed.

@pleshakov IIUC, isn't this test already achieving what this issue expects? - https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/tests/httproute-request-header-modifier.go

that tests works for HTTPRoutes. However, there is no such test for GRPCRoutes.

I'd also double check with @gnossen who authored first GRPC conformance tests https://github.com/kubernetes-sigs/gateway-api/pull/2745

yashvardhan-kukreja commented 5 months ago

that tests works for HTTPRoutes. However, there is no such test for GRPCRoutes.

Gotcha, that makes sense :)

k8s-triage-robot commented 2 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

sjberman commented 2 weeks ago

@yashvardhan-kukreja have you been working on this?