search

kubernetes-sigs / gateway-api

Repository for the next iteration of composite service (e.g. Ingress) and load balancing APIs.
https://gateway-api.sigs.k8s.io
Apache License 2.0
1.68k stars 441 forks source link

Request to include the certificate/s in the CapturedResponse of the conformance test #3020

Open pramodrj07 opened 2 months ago

pramodrj07 commented 2 months ago

Request to include the certificate/s in the CapturedResponse of the conformance test:

To verify the certificate served by the listener/service:

During our testing we found that roundtripper.CapturedResponse does not have a certificates field similar to http.Response(https://github.com/golang/go/blob/master/src/crypto/tls/common.go#L265). It would come in handy for testing as we currently have a wrapper for the same.

or If there is any other way in which this is already done, It would be great to know about it

youngnick commented 1 month ago

/assign @snehachhabria

k8s-ci-robot commented 1 month ago

@youngnick: GitHub didn't allow me to assign the following users: snehachhabria.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/kubernetes-sigs/gateway-api/issues/3020#issuecomment-2121350121): >/assign @snehachhabria Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
snehachhabria commented 1 month ago

/assign @snehachhabria

snehachhabria commented 1 month ago

Per the discussion on this issue on the meeting, currently there are no tests in the conformance that are asserting on this, however exposing this will allow the extension of tests to make these assertions as well in the future.

If an unexpected cert is provided there will be a TLS connection error and there is no need to validate the cert in this scenario but for success scenarios additional validation will help assert the cert details.