kubernetes-sigs / gateway-api

Repository for the next iteration of composite service (e.g. Ingress) and load balancing APIs.
https://gateway-api.sigs.k8s.io
Apache License 2.0
1.67k stars 437 forks source link

Fix the missing example in HTTP rewrite #3126

Closed spacewander closed 2 weeks ago

spacewander commented 3 weeks ago

Also give them clearer names. Signed-off-by: spacewander spacewanderlzx@gmail.com

What type of PR is this?

/kind documentation

What this PR does / why we need it:

There is expected to be one more example in the rewrite section.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE
k8s-ci-robot commented 3 weeks ago

Hi @spacewander. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, spacewander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/gateway-api/blob/main/OWNERS)~~ [robscott] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
spacewander commented 2 weeks ago

@robscott Would you review this PR again? Thanks!

robscott commented 2 weeks ago

Thanks @spacewander! Sorry I'd lost track of this one!

/lgtm