search

kubernetes-sigs / gateway-api

Repository for the next iteration of composite service (e.g. Ingress) and load balancing APIs.
https://gateway-api.sigs.k8s.io
Apache License 2.0
1.67k stars 437 forks source link

Fix v1beta1 HTTPHeaderName alias #3127

Closed spencerhance closed 3 weeks ago

spencerhance commented 3 weeks ago

What type of PR is this? /kind bug

What this PR does / why we need it: Currently, the v1beta1 HTTPHeaderName aliases directly to v1.HeaderName instead of v1.HTTPHeaderName (which then aliases to v1.HeaderName).

Does this PR introduce a user-facing change?:

NONE
spencerhance commented 3 weeks ago

/assign @robscott

spencerhance commented 3 weeks ago

Not sure if this should be kind/bug or kind/cleanup...

robscott commented 3 weeks ago

Thanks @spencerhance!

/lgtm /approve

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, spencerhance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/gateway-api/blob/main/OWNERS)~~ [robscott] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment