kubernetes-sigs / gateway-api

Repository for the next iteration of composite service (e.g. Ingress) and load balancing APIs.
https://gateway-api.sigs.k8s.io
Apache License 2.0
1.67k stars 437 forks source link

Backendref httproute filter request redirect #3134

Open arnaud-tincelin opened 3 weeks ago

arnaud-tincelin commented 3 weeks ago

What type of PR is this? /kind test /area conformance

What this PR does / why we need it:

Which issue(s) this PR fixes:

2936

Does this PR introduce a user-facing change?:

NONE
linux-foundation-easycla[bot] commented 3 weeks ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: arnaud-tincelin Once this PR has been reviewed and has the lgtm label, please assign danwinship for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/gateway-api/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 3 weeks ago

Welcome @arnaud-tincelin!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 3 weeks ago

Hi @arnaud-tincelin. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
arnaud-tincelin commented 3 weeks ago

thank you @mlavacca, it's a lot clearer!

I am still working on the code based on your comments and I am trying to run the tests on an AKS with istio gateway or azure gateway but in both cases the tests end up in timeout. Is there something I am missing?

The tests seem to be stuck on this:

helpers.go:223: 2024-06-06T11:26:27.841628413+02:00: gateway-conformance-infra/gateway-add-listener Gateway not Accepted yet
    helpers.go:222: 2024-06-06T11:26:28.841559903+02:00: Accepted condition set to Status False with Reason Accepted, expected Status True
    helpers.go:222: 2024-06-06T11:26:28.841667255+02:00: Accepted was not in conditions list [[{Accepted False 1 2024-06-06 11:14:31 +0200 CEST Accepted Gateway does not have annotation to reference Application Gateway for Containers resource}]]

and I started the tests with

go test ./conformance -run TestConformance -args \
    --gateway-class=istio \ # or azure-alb-external
    --supported-features=Gateway,HTTPRoute,HTTPRouteBackendPathRedirect`