search

kubernetes-sigs / gateway-api

Repository for the next iteration of composite service (e.g. Ingress) and load balancing APIs.
https://gateway-api.sigs.k8s.io
Apache License 2.0
1.77k stars 458 forks source link

Outputs ns for gateways in gwctl #3136

Closed xtineskim closed 3 months ago

xtineskim commented 3 months ago

What type of PR is this?

What this PR does / why we need it: Related to small usability for gwctl. Now the following output for gwctl get gateways -A

NAMESPACE  NAME    CLASS   ADDRESSES       PORTS  PROGRAMMED  AGE
cilium     cilium  cilium  172.18.255.200  80     True        2h
default    cilium  cilium  172.18.255.201  80     True        2h

Which issue(s) this PR fixes: Related to https://github.com/kubernetes-sigs/gateway-api/issues/3133

Fixes #

Does this PR introduce a user-facing change?:

NONE
k8s-ci-robot commented 3 months ago

Hi @xtineskim. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
gauravkghildiyal commented 3 months ago

Thanks @xtineskim!. This LGTM

/ok-to-test /lgtm /approve

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauravkghildiyal, xtineskim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[gwctl/OWNERS](https://github.com/kubernetes-sigs/gateway-api/blob/main/gwctl/OWNERS)~~ [gauravkghildiyal] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment