search

kubernetes-sigs / gateway-api

Repository for the next iteration of composite service (e.g. Ingress) and load balancing APIs.
https://gateway-api.sigs.k8s.io
Apache License 2.0
1.67k stars 437 forks source link

conformance: Add Cilium report for v1.1.0 #3137

Closed sayboras closed 1 week ago

sayboras commented 3 weeks ago

What type of PR is this?

/kind documentation

What this PR does / why we need it: conformance: Add Cilium report for v1.1.0

Which issue(s) this PR fixes:

N/A

Does this PR introduce a user-facing change?:

NONE
k8s-ci-robot commented 3 weeks ago

Hi @sayboras. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
robscott commented 2 weeks ago

Thanks @sayboras! Any reason this is still a draft PR?

sayboras commented 2 weeks ago

Any reason this is still a draft PR?

Thanks for the ping, I was thinking about how to make the reproduce steps easier for end-users. Pointing to GHA job is a good first step imo.

sayboras commented 2 weeks ago

I think the report filename needs to be changed according to the new guidelines here: https://github.com/kubernetes-sigs/gateway-api/tree/main/conformance/reports

Thanks, I have updated the report name as well as README file.

robscott commented 1 week ago

Thanks @sayboras!

/lgtm /approve /ok-to-test

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, sayboras

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[conformance/OWNERS](https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/OWNERS)~~ [robscott] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment