search

kubernetes-sigs / gateway-api

Repository for the next iteration of composite service (e.g. Ingress) and load balancing APIs.
https://gateway-api.sigs.k8s.io
Apache License 2.0
1.67k stars 437 forks source link

Support Request Timeouts for GRPCRoute #3139

Open arkodg opened 3 weeks ago

arkodg commented 3 weeks ago

What would you like to be added:

A request.Timeout field within GRPCRoute similar to the one added in HTTPRoute as part of https://gateway-api.sigs.k8s.io/geps/gep-1742/

Why this is needed:

  1. Set a request timeout for unary rpc, that may vary from the default timeout of the implementation
  2. Disable timeouts (set to 0s) for streaming rpc
arkodg commented 3 weeks ago

cc @robscott @frankbu @gnossen

robscott commented 3 weeks ago

Good call @arkodg! I think this one should be relatively straightforward, but because it's a new API field in a GA resource, we'll likely need to track it with a separate GEP. Do you mind adding this to https://github.com/kubernetes-sigs/gateway-api/discussions/3103 if you think you'd have time to lead this in v1.2?

arkodg commented 3 weeks ago

sure @robscott done