kubernetes-sigs / gateway-api

Repository for the next iteration of composite service (e.g. Ingress) and load balancing APIs.
https://gateway-api.sigs.k8s.io
Apache License 2.0
1.67k stars 437 forks source link

fix: change report API version #3153

Closed mlavacca closed 1 week ago

mlavacca commented 2 weeks ago

What type of PR is this?

/kind bug /area conformance

What this PR does / why we need it:

With the graduation of the conformance test suite we bumped the ConformanceReport API to v1. However, we did not change the APIVersion of the reports created by the suite accordingly. The result was that we were creating v1 reports with v1alpha1 set as APIVersion. This PR fixes such a problem.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

The generated conformance report API version is set to v1 instead of v1alpha1.
k8s-ci-robot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[conformance/OWNERS](https://github.com/kubernetes-sigs/gateway-api/blob/main/conformance/OWNERS)~~ [mlavacca] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
robscott commented 2 weeks ago

Thanks @mlavacca! LGTM once gofumpt check passes

mlavacca commented 2 weeks ago

Thanks @mlavacca! LGTM once gofumpt check passes

It's fixed now, PTAL :)

youngnick commented 1 week ago

/lgtm