Open gauravkghildiyal opened 1 month ago
Can I assign it to myself? I want to try it @gauravkghildiyal
Hi @deszhou, sure go ahead, though there's a few minor open questions here which may need to be ironed out. Like for example what exactly would the following output:
gwctl get policies
gwctl describe policies
Would be nice if you can give a sample of what you have in mind before diving deep
Hi @deszhou, sure go ahead, though there's a few minor open questions here which may need to be ironed out. Like for example what exactly would the following output:
gwctl get policies gwctl describe policies
Would be nice if you can give a sample of what you have in mind before diving deep
gwctl get policies -A
NAME KIND TARGET NAME TARGET KIND POLICY TYPE AGE
health-check-gateway HealthCheckPolicy.foo.com foo-gateway Gateway Inherited 20d
foo-gatewayclass GatewayClass Inherited 20d
timeout-policy-gatewayclass TimeoutPolicy.bar.com foo-gatewayclass Gatewayclass Direct 5m
timeout-policy-httproute TimeoutPolicy.bar.com foo-httproute HTTPRoute Direct 13m
NAME KIND TARGET REFS POLICY TYPE AGE
health-check-gateway HealthCheckPolicy.foo.com foo-gateway (Gateway),foo-gatewayclass (GatewayClass) Inherited 20d
timeout-policy-gatewayclass TimeoutPolicy.bar.com foo-gatewayclass (Gatewayclass) Direct 5m
timeout-policy-httproute TimeoutPolicy.bar.com foo-httproute (HTTPRoute) Direct 13m
gwctl describe policies health-check-gateway
Name: health-check-gateway
Group: foo.com
Kind: HealthCheckPolicy
Inherited: "true"
Spec:
...
targetRefs:
- group: gateway.networking.k8s.io
kind: Gateway
name: foo-gateway
- group: gateway.networking.k8s.io
kind: GatewayClass
name: foo-gatewayclass
Which of these two output formats do you think is better for gwctl get policies
, or do you have any suggestions for improving the output format?
Let's choose the "comma-separated one" which is consistent with others. Let's just display 2 targets and then +n more pattern.
Though the other one also seems good but we can revisit this later.
/assign
As per recent updates to the Policy related GEPs in https://github.com/kubernetes-sigs/gateway-api/discussions/2927#discussioncomment-8991869, Policies are now allowed to target multiple resources i.e.
targetRefs
(which previously was limited to a singletargetRef
).Make gwctl work with this new pattern. Common places that need to be updated include:
gwctl get policies
/area gwctl /kind feature