Open jgao1025 opened 2 months ago
/kind documentation
/good-first-issue /help
@jgao1025: This request has been marked as suitable for new contributors.
Please ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met.
If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue
command.
Hey @jgao1025 I would like to work on this issue, as I am starting with kubernetes and have gone through basics, it would be great to get assigned this good first issue to start with, if this issue is open till yet.
Yes, it is still open. I will assign it to you.
/assign @Nishant-k-sagar
hey @jgao1025 i will complete this issue within upcoming day,
tell me any changes needed.
attached image shows the updation in the code.
Hi @Nishant-k-sagar,
I would think to add this in the prerequisite part too but my opinon is not very strong and I am not the member of this project. I also am not sure if installing multiple container runtimes on a local machine is a good idea.
I would suggest you to raise a PR and let a member to review it.
Hi @Nishant-k-sagar, this issue is about specifying in the verify section that docker is a dependency. Feel free to raise a PR with your proposed changes, then it'll be reviewed 👍
Not a huge deal, but just a heads up for the future: these issues need to go through triage prior to being started please (though it may be fair to say we need to make some improvements to the tooling and documentation around this).
Background
In many verification scripts (triggered by running
make verify
), Docker is frequently used as a pre-check tool in many instances.Changes
It is would be nice to mention in the Dev Guide that installing Docker as a runtime container is preferable.
How to start work on this?
Please follow this section.
Original request
_Originally posted by @mlavacca in https://github.com/kubernetes-sigs/gateway-api/pull/3167#discussion_r1714869211_