Conditions for Policy Attachment

kubernetes-sigs / gateway-api

Repository for the next iteration of composite service (e.g. Ingress) and load balancing APIs.

https://gateway-api.sigs.k8s.io

Apache License 2.0

1.68k stars 444 forks source link

Conditions for Policy Attachment #738

Open robscott opened 2 years ago

robscott commented 2 years ago

What would you like to be added: As discussed in https://github.com/kubernetes-sigs/gateway-api/pull/715#discussion_r672724388 and https://github.com/kubernetes-sigs/gateway-api/issues/590, any form of status per policy is going to be complex. These conditions may need to be per controller or even per referencing resource (ie policy targeting Route that is also targeted by several Gateways).

Why this is needed: Although each implementation can currently take whichever approach makes the most sense for them, it would be better to standardize on this.

GEP: #713

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

youngnick commented 2 years ago

/remove-lifecycle rotten

We will need to address this more, but it needs some more work on actually using Policy.

k8s-triage-robot commented 2 years ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

hbagdi commented 2 years ago

/lifecycle frozen

shaneutt commented 1 year ago

Where are we at with this one? :thinking:

robscott commented 1 year ago

I think we still need this.

/help

k8s-ci-robot commented 1 year ago

@robscott: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

Why are we solving this issue?
To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
Does this issue have zero to low barrier of entry?
How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to [this](https://github.com/kubernetes-sigs/gateway-api/issues/738): >I think we still need this. > >/help Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

shaneutt commented 1 year ago

There's been a single status for policy attachment added so far which is great, but for GA this isn't a blocker. We want this feature, but we consider it low priority until v1.0.0/GA is complete and don't believe we will have bandwidth for it until then.

mikemorris commented 3 months ago

This may be a bit controversial given how complex policy already is, but we have a use case in Istio for adding a PartiallyInvalid PolicyConditionType and UnsupportedValue PolicyConditonReason to mirror the existing type and reason in HTTPRoute.