search

kubernetes-sigs / gcp-compute-persistent-disk-csi-driver

The Google Compute Engine Persistent Disk (GCE PD) Container Storage Interface (CSI) Storage Plugin.
Apache License 2.0
163 stars 144 forks source link

Validate the driver successfully came up in k8s test #139

Open msau42 opened 5 years ago

msau42 commented 5 years ago

Need to deal with the master DaemonSet pod pending

fejta-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

msau42 commented 5 years ago

/remove-lifecycle stale /lifecycle frozen

msau42 commented 4 years ago

https://github.com/kubernetes/kubernetes/pull/93120 may help validate the driver is registered successfully on all nodes.

It would be nice to also have a check that the controller deployment came up successfully

mattcary commented 4 years ago

Is that a matter of polling for objects defined in the appropriate configs in cluster/addons?

msau42 commented 4 years ago

Yes, namely the Deployment in the gce-pd-csi-driver namespace.

mattcary commented 4 years ago

/assign

Ok I'll take this.

mattcary commented 4 years ago

Actually, the k/k change will not improve the k8s-integration test in this repo as it deploys the driver from a shell script.

I have a PR at https://github.com/mattcary/gcp-compute-persistent-disk-csi-driver/tree/wait (currently stacked up behind #610) that will fix the change in this repo too.