kubernetes-sigs / gcp-compute-persistent-disk-csi-driver

The Google Compute Engine Persistent Disk (GCE PD) Container Storage Interface (CSI) Storage Plugin.
Apache License 2.0
163 stars 144 forks source link

Updating IOPS/Throughput for hyperdisk balanced disk #1671

Closed nikhilkathare closed 2 weeks ago

nikhilkathare commented 6 months ago

We can specify provisioned-iops-on-create and provisioned-throughput-on-create in Storage class but that will be only helpful for on create. But we cannot update the values later for the PVs. Using following examples command we can specify IOPS AND Throughput for hyperdisk-balanced for both during create and update. Is there any plan to support following functionality for PersistentVolume using CSI driver. ?

Example 1) we can create disk with following command where we can sepcify IOPS and Throughput : Ref: https://cloud.google.com/kubernetes-engine/docs/how-to/persistent-volumes/hyperdisk#gcloud

gcloud compute disks create DISK_NAME \ --size=SIZE \ --source-snapshot=SNAPSHOT_NAME \ --provisioned-throughput=TRHROUGHPUT_LIMIT \ --provisioned-iops=IOPS_LIMIT \ --type=hyperdisk-balanced

2) Update disk IOPS and Throughput using following gcloud command. Ref : https://cloud.google.com/compute/docs/disks/modify-hyperdisks#gcloud

gcloud compute disks update DISK_NAME \ --size=DISK_SIZE \ --provisioned-iops=IOPS_LIMIT \ --provisioned-throughput=THROUGHPUT_LIMIT

nikhilkathare commented 5 months ago

Hi to extend above question. In k8s we have VolumeAttributesClass to support configuring IOPS and Throughput. https://kubernetes.io/blog/2023/12/15/kubernetes-1-29-volume-attributes-class/

Is there any plan to support VolumeAttributesClass in GCP CSI driver ?

k8s-triage-robot commented 2 months ago

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot commented 1 month ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot commented 2 weeks ago

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

You can:

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

k8s-ci-robot commented 2 weeks ago

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to [this](https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/issues/1671#issuecomment-2409099040): >The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. > >This bot triages issues according to the following rules: >- After 90d of inactivity, `lifecycle/stale` is applied >- After 30d of inactivity since `lifecycle/stale` was applied, `lifecycle/rotten` is applied >- After 30d of inactivity since `lifecycle/rotten` was applied, the issue is closed > >You can: >- Reopen this issue with `/reopen` >- Mark this issue as fresh with `/remove-lifecycle rotten` >- Offer to help out with [Issue Triage][1] > >Please send feedback to sig-contributor-experience at [kubernetes/community](https://github.com/kubernetes/community). > >/close not-planned > >[1]: https://www.kubernetes.dev/docs/guide/issue-triage/ Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.