Closed pwschuurman closed 1 month ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: pwschuurman
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
/retest
What type of PR is this? /kind test
What this PR does / why we need it: Add some improvements to the e2e test suite runner:
--extra-driver-flags
to the e2e test runner. This allows additional flags to be passed into the PDCSI driver during the e2e test. This is useful when locally testing a new feature that is hidden behind a feature flag, and the feature is not yet ready to be default enabled in the e2e test.testAttachAndMount
function inmulti_zone_e2e_test.go
to pass in a parameter struct of booleans. These parameters are used to control attach and mount characteristics. This disambiguates the ordering of attach/mount parameters (currently there are consecutive booleans passed in with this function call).testAttachAndMount
to properly call NodeUnpublish/NodeUnstage/ControllerUnpublish, depending on the current progress of the test. Currently the Node functions are called even if the reciprocal Publish/Stage calls are not successful in the test.ForceChmod
to only recursivelychmod
when the filesystem is writeable (eg:readonly
is false). This allows tests that use this function to pass correctly (currently they fail on thechmod
step).Does this PR introduce a user-facing change?: