Closed pwschuurman closed 3 months ago
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: pwschuurman
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/assign @mattcary
/retest
/retest
/lgtm
What type of PR is this? /kind feature
What this PR does / why we need it: Add support for
multi-zone
volume handle provisioning. Volumes created with theenable-multi-zone-provisioning: true
parameter will be created with multiple underlying disks, one per specified zone. The underlying volume returned will specify the keywordmulti-zone
in place of thezone
field. See https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1616 for more details on the syntax. 1) If there are zones specified in the requisite topologies, one disk will be created per zone 2) If there are no zones specified in the requisite topologies, one disk will be created per zone in all zones in the driver's default region (where the particular disk type is supported).Multi-zone volumes can be created from three sources: 1) PD images (ROX mode) 2) PD Snapshots (ROX mode) 3) Empty disks (RWO mode)
Deletion will inspect all disks that match the volume handle name, for all zones in the driver's default region.
Special notes for your reviewer:
This adds some additional e2e tests, that are not yet runnable, due to API support being in alpha. These have been run on a locally project that has alpha support, and can be replicated by running:
Does this PR introduce a user-facing change?: