search

kubernetes-sigs / gcp-compute-persistent-disk-csi-driver

The Google Compute Engine Persistent Disk (GCE PD) Container Storage Interface (CSI) Storage Plugin.
Apache License 2.0
163 stars 143 forks source link

Adding missing libgpg-error.so.0 required by nvme-cli #1760

Closed pwschuurman closed 3 months ago

pwschuurman commented 3 months ago

What type of PR is this? /kind bug

What this PR does / why we need it: The command /usr/bin/nvme requires this shared library. This is used to validate nvme device symlinks. This library is required in Bookworm (after we migrated from Bullseye in #1694)

Validated by running ./hack/verify_docker_deps.h

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Fixes NVMe support in NodeStage and NodePublish
pwschuurman commented 3 months ago

/assign @Sneha-at

Sneha-at commented 3 months ago

/lgtm /approve

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pwschuurman, Sneha-at

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/OWNERS)~~ [pwschuurman] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pwschuurman commented 3 months ago

/retest

pwschuurman commented 3 months ago

/cherry-pick release-1.14

pwschuurman commented 3 months ago

/cherry-pick release-1.13

pwschuurman commented 3 months ago

/cherry-pick release-1.12

pwschuurman commented 3 months ago

/cherry-pick release-1.11

pwschuurman commented 3 months ago

/cherry-pick release-1.10

pwschuurman commented 3 months ago

/cherry-pick release-1.9

k8s-infra-cherrypick-robot commented 3 months ago

@pwschuurman: new pull request created: #1765

In response to [this](https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1760#issuecomment-2190211984): >/cherry-pick release-1.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 3 months ago

@pwschuurman: new pull request created: #1766

In response to [this](https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1760#issuecomment-2190212026): >/cherry-pick release-1.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 3 months ago

@pwschuurman: new pull request created: #1767

In response to [this](https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1760#issuecomment-2190212091): >/cherry-pick release-1.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 3 months ago

@pwschuurman: new pull request created: #1768

In response to [this](https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1760#issuecomment-2190212188): >/cherry-pick release-1.11 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 3 months ago

@pwschuurman: new pull request created: #1769

In response to [this](https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1760#issuecomment-2190212284): >/cherry-pick release-1.10 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
k8s-infra-cherrypick-robot commented 3 months ago

@pwschuurman: new pull request created: #1770

In response to [this](https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1760#issuecomment-2190212466): >/cherry-pick release-1.9 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.