search

kubernetes-sigs / gcp-compute-persistent-disk-csi-driver

The Google Compute Engine Persistent Disk (GCE PD) Container Storage Interface (CSI) Storage Plugin.
Apache License 2.0
163 stars 143 forks source link

Update run-e2e.sh to use prow-build SA by in presubmit #1764

Closed pwschuurman closed 3 months ago

pwschuurman commented 3 months ago

What type of PR is this? /kind failing-test

What this PR does / why we need it: This fixes the e2e prow tests (presubmit) to run with Boskos projects. e2e tests have been failing since https://github.com/kubernetes/test-infra/pull/32809 was submitted

Does this PR introduce a user-facing change?:

NONE
pwschuurman commented 3 months ago

/retest

mattcary commented 3 months ago

/lgtm /approve

pwschuurman commented 3 months ago

/hold Rollback in https://github.com/kubernetes/test-infra/pull/32841. The current plan of record is to keep using the default SA, but just to add additional cloudkms permissions in the k8s.io boskos projects.

pwschuurman commented 3 months ago

The current plan of record is to keep using the default SA, but just to add additional cloudkms permissions in the k8s.io boskos projects.

Plan of record has changed. We're migrating to using prow-build, now that prow-build has roles/iam.serviceAccountUser permission.

mattcary commented 3 months ago

/lgtm /approve

k8s-ci-robot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, pwschuurman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/OWNERS)~~ [mattcary,pwschuurman] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pwschuurman commented 3 months ago

/retest

pwschuurman commented 3 months ago

/retest

k8s-ci-robot commented 3 months ago

@pwschuurman: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e c6dece0b65fdad9dc6415fba791a7418bbfbbce5 link true /test pull-gcp-compute-persistent-disk-csi-driver-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
pwschuurman commented 3 months ago

Plan of record has changed. We're migrating to using prow-build, now that prow-build has roles/iam.serviceAccountUser permission.

Due to cross-project service account impersonation restrictions, we'll need to keep using the default compute service account. The default compute service account was updated to have the appropriate cloudkms permissions in https://github.com/kubernetes/k8s.io/pull/6921#issuecomment-2193161157

Will close this out once we confirm that the e2e tests are now passing.

/hold Wait for passing e2e tests before closing.

pwschuurman commented 3 months ago

Closing, since we are continuing to use the default SA, with updated permissions.