search

kubernetes-sigs / gcp-compute-persistent-disk-csi-driver

The Google Compute Engine Persistent Disk (GCE PD) Container Storage Interface (CSI) Storage Plugin.
Apache License 2.0
159 stars 141 forks source link

Update LSSD raiding logic to support NVME VMs #1771

Closed Sneha-at closed 4 days ago

Sneha-at commented 3 weeks ago

What type of PR is this? /kind bug

What this PR does / why we need it: This updates the RAIDing logic for Local SSD caching to exclude PDs from raiding. Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer: Validated Data cache E2E tests on c3-standard-22-lssd Does this PR introduce a user-facing change?:

NONE
Sneha-at commented 3 weeks ago

/assign @mattcary

mattcary commented 3 weeks ago

/lgtm /approve

Sneha-at commented 3 weeks ago

/hold running some checks for this

Sneha-at commented 1 week ago

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Sneha-at commented 1 week ago

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Sneha-at commented 1 week ago

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Sneha-at commented 1 week ago

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Sneha-at commented 1 week ago

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Sneha-at commented 1 week ago

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Sneha-at commented 5 days ago

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Sneha-at commented 5 days ago

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Sneha-at commented 5 days ago

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Sneha-at commented 4 days ago

/unhold

mattcary commented 4 days ago

/lgtm /approve

Sneha-at commented 4 days ago

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

Sneha-at commented 4 days ago

/test pull-gcp-compute-persistent-disk-csi-driver-e2e

mattcary commented 4 days ago

/lgtm /approve

k8s-ci-robot commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, Sneha-at

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/release-999.2/OWNERS)~~ [mattcary] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
k8s-ci-robot commented 4 days ago

@Sneha-at: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-e2e 7eddb8db09da4188c8b16dc7a46c7c4ff254712e link true /test pull-gcp-compute-persistent-disk-csi-driver-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
mattcary commented 4 days ago

e2e test failing due to known issue with snapshot delete operations. Force-merging to work around that.