search

kubernetes-sigs / gcp-compute-persistent-disk-csi-driver

The Google Compute Engine Persistent Disk (GCE PD) Container Storage Interface (CSI) Storage Plugin.
Apache License 2.0
163 stars 146 forks source link

Fix ci tests #1831

Closed travisyx closed 2 months ago

travisyx commented 2 months ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change /kind bug /kind cleanup /kind design /kind documentation

/kind failing-test

/kind feature /kind flake

What this PR does / why we need it:

This PR modifies the run-k8s-integration-ci.sh script to fix the test focuses and machine types when running modify_volume tests.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

A run of the failing tests can be seen here.

Does this PR introduce a user-facing change?:

NONE
k8s-ci-robot commented 2 months ago

Hi @travisyx. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
amacaskill commented 2 months ago

/ok-to-test /approve /lgtm

k8s-ci-robot commented 2 months ago

@travisyx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gcp-compute-persistent-disk-csi-driver-verify 05599f28fc40a1cc933c8d90bec2fff0dcc36211 link true /test pull-gcp-compute-persistent-disk-csi-driver-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
amacaskill commented 2 months ago

/lgtm /approve

k8s-ci-robot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amacaskill, travisyx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/OWNERS)~~ [amacaskill] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
travisyx commented 2 weeks ago

/cherry-pick release-1.15

k8s-infra-cherrypick-robot commented 2 weeks ago

@travisyx: only kubernetes-sigs org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to [this](https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1831#issuecomment-2457873668): >/cherry-pick release-1.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
amacaskill commented 2 weeks ago

/cherry-pick release-1.15

k8s-infra-cherrypick-robot commented 2 weeks ago

@amacaskill: new pull request created: #1859

In response to [this](https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1831#issuecomment-2457952069): > >/cherry-pick release-1.15 > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.