search

kubernetes-sigs / gcp-compute-persistent-disk-csi-driver

The Google Compute Engine Persistent Disk (GCE PD) Container Storage Interface (CSI) Storage Plugin.
Apache License 2.0
163 stars 146 forks source link

Map RESOURCE_OPERATION_RATE_EXCEEDED to ResourceExhausted #1847

Closed amacaskill closed 1 month ago

amacaskill commented 1 month ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change /kind bug

/kind cleanup

/kind design /kind documentation /kind failing-test /kind feature /kind flake

What this PR does / why we need it: Map RESOURCE_OPERATION_RATE_EXCEEDED to ResourceExhausted. Prevents us from being alerted for errors like:

CreateVolume failed to create single zonal disk pvc-xxx: failed to insert zonal disk: unknown error when polling the operation: rpc error: code = Internal desc = operation operation-xxx failed (RESOURCE_OPERATION_RATE_EXCEEDED): Operation rate exceeded for resource 'projects/xxx/global/snapshots/snapshot-pvc-xxx'. Too frequent operations from the source resource.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Map RESOURCE_OPERATION_RATE_EXCEEDED to ResourceExhausted.
k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amacaskill, leiyiz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/blob/master/OWNERS)~~ [amacaskill,leiyiz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
amacaskill commented 1 month ago

/cherry-pick release-1.15

k8s-infra-cherrypick-robot commented 1 month ago

@amacaskill: new pull request created: #1848

In response to [this](https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/1847#issuecomment-2430384313): >/cherry-pick release-1.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.