search

kubernetes-sigs / gcp-compute-persistent-disk-csi-driver

The Google Compute Engine Persistent Disk (GCE PD) Container Storage Interface (CSI) Storage Plugin.
Apache License 2.0
158 stars 140 forks source link

Snapshot tests #191

Open davidz627 opened 5 years ago

davidz627 commented 5 years ago

I think we need snapshot E2E tests to verify that entire snapshot lifecycle is tested, for example I don't think we test the codepath to check create volume with snapshot source works properly.

/assign @jingxu97

fejta-bot commented 5 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

davidz627 commented 5 years ago

/remove-lifecycle stale @jingxu97 has this been covered with existing tests?

msau42 commented 5 years ago

E2E tests were added, but we should also consider running the K8s snapshot tests too. We'll need to put in the plumbing to bring up an alpha cluster to do that

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

davidz627 commented 4 years ago

/remove-lifecycle stale @jingxu97 in case there is status update

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

davidz627 commented 4 years ago

/remove-lifecycle stale We could run the snapshots tests from the integration test suite now. They require a focusing on the snapshots [feature] tag and deploying the alpha/dev version of the driver.

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

msau42 commented 4 years ago

/lifecycle frozen