search

kubernetes-sigs / gcp-compute-persistent-disk-csi-driver

The Google Compute Engine Persistent Disk (GCE PD) Container Storage Interface (CSI) Storage Plugin.
Apache License 2.0
163 stars 146 forks source link

Change k8s integration test to use git sha for latest image testing #382

Open msau42 opened 5 years ago

msau42 commented 5 years ago

Instead of using "latest" tag, which has problems with tags potentially changing in the middle of test runs, we should use a stable image tag, such as git commit sha.

/kind bug

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

davidz627 commented 4 years ago

/remove-lifecycle stale HIGH PRIORITY - CI IS NOT RUNNING WITH NEW IMAGES

davidz627 commented 4 years ago

/assign

davidz627 commented 4 years ago

Looks like we're actually testing the canary image in quay for now. So we're getting the signal we want although not in the "best" way. Lowering priority

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

msau42 commented 4 years ago

/lifecycle frozen