Tests for idempotency - Githubissues

kubernetes-sigs / gcp-compute-persistent-disk-csi-driver

The Google Compute Engine Persistent Disk (GCE PD) Container Storage Interface (CSI) Storage Plugin.

Apache License 2.0

163 stars 146 forks source link

Tests for idempotency #568

Open msau42 opened 4 years ago

msau42 commented 4 years ago

We've fixed some issues regarding idempotent calls, such as https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/563 and https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/pull/527.

It would be good to test this in general so we can catch other issues. Some suggestions:

For testing, reduce the sidecar controller timeouts to 1s so that a controller call will always timeout and retry.
Incorporate more idempotency testing with csi-sanity, such as https://github.com/kubernetes-csi/csi-test/pull/229

fejta-bot commented 4 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

mattcary commented 4 years ago

/remove-lifecycle stale

fejta-bot commented 3 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale

mattcary commented 3 years ago

/lifecycle frozen

On Tue, Feb 2, 2021 at 9:52 AM fejta-bot notifications@github.com wrote:

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta https://github.com/fejta. /lifecycle stale

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kubernetes-sigs/gcp-compute-persistent-disk-csi-driver/issues/568#issuecomment-771838665, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIJCBAEY5B3L3D52FG35VMTS5A3WBANCNFSM4PVX6DXQ .