search

kubernetes-sigs / hierarchical-namespaces

Home of the Hierarchical Namespace Controller (HNC). Adds hierarchical policies and delegated creation to Kubernetes namespaces for improved in-cluster multitenancy.
Apache License 2.0
610 stars 105 forks source link

Cherry pick of #283, #286, #294 #290

Closed keisukesakasai closed 1 year ago

keisukesakasai commented 1 year ago

Cherry pick of https://github.com/kubernetes-sigs/hierarchical-namespaces/pull/283 , https://github.com/kubernetes-sigs/hierarchical-namespaces/pull/286 , https://github.com/kubernetes-sigs/hierarchical-namespaces/pull/294 on master.

https://github.com/kubernetes-sigs/hierarchical-namespaces/pull/283: Show HierarchicalResourceQuota status by kubectl-hns https://github.com/kubernetes-sigs/hierarchical-namespaces/pull/286 : Remove unneeded dependency to k8s.io/kubernetes https://github.com/kubernetes-sigs/hierarchical-namespaces/pull/294: Remove unneeded replace clause from go.mod

The discussion regarding the content can be found here: https://github.com/kubernetes-sigs/hierarchical-namespaces/pull/284#issuecomment-1566706843

k8s-ci-robot commented 1 year ago

Hi @keisukesakasai. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
keisukesakasai commented 1 year ago

Hi, @adrianludwin Could you please check this PR, thanks.

/assign @adrianludwin

rjbez17 commented 1 year ago

/ok-to-test /lgtm

@adrianludwin can approve when ready

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin, keisukesakasai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/hierarchical-namespaces/blob/v1.1/OWNERS)~~ [adrianludwin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment