search

kubernetes-sigs / hierarchical-namespaces

Home of the Hierarchical Namespace Controller (HNC). Adds hierarchical policies and delegated creation to Kubernetes namespaces for improved in-cluster multitenancy.
Apache License 2.0
619 stars 105 forks source link

Remove unneeded replace clause from go.mod #294

Closed mochizuki875 closed 1 year ago

mochizuki875 commented 1 year ago

Remove unneeded replace clause from go.mod. It was added as workaround of k8s.io/kubernetes import error in #283 . (ref. https://github.com/kubernetes/kubernetes/issues/79384)

However, k8s.io/kubernetes has been removed in #286 as unneeded dependency so replace clause is unneeded too.

related: https://github.com/kubernetes-sigs/hierarchical-namespaces/pull/290#pullrequestreview-1457869921

k8s-ci-robot commented 1 year ago

Hi @mochizuki875. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mochizuki875 commented 1 year ago

/assign @adrianludwin /cc @erikgb

erikgb commented 1 year ago

Thanks! /lgtm

rjbez17 commented 1 year ago

/ok-to-test

rjbez17 commented 1 year ago

/approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mochizuki875, rjbez17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/hierarchical-namespaces/blob/master/OWNERS)~~ [rjbez17] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment