search

kubernetes-sigs / hierarchical-namespaces

Home of the Hierarchical Namespace Controller (HNC). Adds hierarchical policies and delegated creation to Kubernetes namespaces for improved in-cluster multitenancy.
Apache License 2.0
619 stars 105 forks source link

Show HierarchicalResourceQuota status by kubectl get #295

Closed mochizuki875 closed 1 year ago

mochizuki875 commented 1 year ago

What type of PR is this?:

/kind feature

What this PR does / why we need it:

We have added kubectl-hns hrq sub-command to show HierarchicalResourceQuota status in easy way.(#283) However, it's not yet possible to achive that using the Kubernetes standard way kubectl get hrq.

$ kubectl get hrq -n test
NAME       AGE
test-hrq   80s

So in this PR, I made it possible to show HierarchicalResourceQuota status by using kubectl get hrq.

$ kubectl get hrq -n test
NAME         REQUEST                                              LIMIT
test-hrq     requests.cpu: 500m/1, requests.memory: 100Mi/200Mi   limits.cpu: 500m/2, limits.memory: 100Mi/500Mi
test-hrq-2   requests.memory: 100Mi/300Mi                         limits.cpu: 500m/1

$ kubectl get hrq --all-namespaces
NAMESPACE   NAME         REQUEST                                              LIMIT
test-2      test-hrq-3   requests.cpu: 0/4, requests.memory: 0/500Mi          limits.cpu: 0/8, limits.memory: 0/750Mi
test        test-hrq     requests.cpu: 500m/1, requests.memory: 100Mi/200Mi   limits.cpu: 500m/2, limits.memory: 100Mi/500Mi
test        test-hrq-2   requests.memory: 100Mi/300Mi                         limits.cpu: 500m/1

Tested:

Unit and E2E tests has passed. I also added test case to HRQ E2E test which is now Pending.

Related:

274

283

289

Special notes for your reviewer:

HierarchicalResourceQuota documentation is proceeding by @zfrhv and @adrianludwin.(#289) If this PR will be merged to v1.1, we should add this feature to it.

k8s-ci-robot commented 1 year ago

Hi @mochizuki875. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mochizuki875 commented 1 year ago

/assign @adrianludwin

mochizuki875 commented 1 year ago

@adrianludwin OK, I've fixed it.

rjbez17 commented 1 year ago

/ok-to-test

This lgtm but I'll let @adrianludwin have final say.

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adrianludwin, mochizuki875

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/hierarchical-namespaces/blob/master/OWNERS)~~ [adrianludwin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mochizuki875 commented 1 year ago

I've fixed conflict. Could anyone please add /lgtm again?