search

kubernetes-sigs / hierarchical-namespaces

Home of the Hierarchical Namespace Controller (HNC). Adds hierarchical policies and delegated creation to Kubernetes namespaces for improved in-cluster multitenancy.
Apache License 2.0
619 stars 105 forks source link

docs: apply k8s style guide to HRQ quickstart example #316

Closed agilgur5 closed 1 year ago

agilgur5 commented 1 year ago

Summary

Apply more of k8s style guide to HRQ quickstart example

Details

k8s-ci-robot commented 1 year ago

Hi @agilgur5. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
agilgur5 commented 1 year ago

@adrianludwin could you review this docs PR as well?

rjbez17 commented 1 year ago

/ok-to-test /lgtm /approve

k8s-ci-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agilgur5, rjbez17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/hierarchical-namespaces/blob/master/OWNERS)~~ [rjbez17] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rjbez17 commented 1 year ago

Looks like there are some merge conflicts. When you have a few, mind fixing them up and we can get this merged in. Thanks!

agilgur5 commented 1 year ago

@rjbez17 rebased and fixed all merge conflicts; needs a new LGTM now

adrianludwin commented 1 year ago

Thanks for this change!

/lgtm