Closed timbyr closed 1 year ago
Welcome @timbyr!
It looks like this is your first PR to kubernetes-sigs/hierarchical-namespaces 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/hierarchical-namespaces has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @timbyr. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: adrianludwin, timbyr
The full list of commands accepted by this bot can be found here.
The pull request process is described here
By default ArgoCD use labels to understand which objects it controls.
When HNC propagates those resources ArgoCD assumes ownership of those resources and attempts to reconcile it with current state, usually leading to deletion of those resources. This causes a feedback loop where ArgoCD requests a deletion of an object, that is blocked by the HNC webhook, and HNC no longer is able to properly manage the resource due to the deletion finaliser set on the resource.
This is similar behaviour to ConfigSync with annotations.
This commit adds an unpropagated-labels command line argument following the implementation of the unpropagated-annotations argument. This allows cluster operators to disable propagation of labels owned by systems like ArgoCD.
Tested: