search

kubernetes-sigs / hierarchical-namespaces

Home of the Hierarchical Namespace Controller (HNC). Adds hierarchical policies and delegated creation to Kubernetes namespaces for improved in-cluster multitenancy.
Apache License 2.0
607 stars 105 forks source link

CGO_ENABLED=0 in building linux binary #346

Closed mist714 closed 6 months ago

mist714 commented 9 months ago

The current binary is dynamic-executable.

$ ldd kubectl-hns_linux_amd64 
    linux-vdso.so.1 (0x00007ffc3034b000)
    libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f608e2d7000)
    /lib64/ld-linux-x86-64.so.2 (0x00007f608e50e000)

This is unavoidable for MacOS and Windows, but since Linux environments are required to operate under the minimum necessary conditions, I think we should make not a dynamic executable but a single-binary. The concern is that the size will increase, but it is smaller than the original binary (62.2 MB -> 47 MB)

$ ls -hl bin/kubectl/kubectl-hns_linux_amd64
-rwxr-xr-x  1   staff    47M 11 14 17:04 bin/kubectl/kubectl-hns_linux_amd64*
linux-foundation-easycla[bot] commented 9 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

k8s-ci-robot commented 9 months ago

Welcome @mist714!

It looks like this is your first PR to kubernetes-sigs/hierarchical-namespaces 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/hierarchical-namespaces has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 9 months ago

Hi @mist714. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rjbez17 commented 7 months ago

/ok-to-test /lgtm

@adrianludwin any concerns here?

rjbez17 commented 6 months ago

/approve

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mist714, rjbez17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/hierarchical-namespaces/blob/master/OWNERS)~~ [rjbez17] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment