Closed manjinder-mckc closed 1 month ago
Hi @manjinder-mckc. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: manjinder-mckc Once this PR has been reviewed and has the lgtm label, please assign tashimi for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Although, I am having second thoughts about keeping the test case since it requires managed labels and annotations to be set in the test environment, not sure if that will be inconvenient to others testing, or if make deploy should handle it (but overkill?) .. open to thoughts.
@manjinder-mckc did you still plan on working on this?
@manjinder-mckc did you still plan on working on this?
@rjbez17 yes, i just got caught up with other stuff and couldn't get it to it. But I will update the tests as soon as I can and have it ready
PR needs rebase.
No rush at all, appreciate you taking the time to help out!On Mar 8, 2024, at 10:14 PM, Manjinder @.***> wrote:
@manjinder-mckc did you still plan on working on this?
@rjbez17 yes, i just got caught up with other stuff and couldn't get it to it. But I will update the tests as soon as I can and have it ready
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the PR is closedYou can:
/remove-lifecycle stale
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the PR is closedYou can:
/remove-lifecycle rotten
/close
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages PRs according to the following rules:
lifecycle/stale
is appliedlifecycle/stale
was applied, lifecycle/rotten
is appliedlifecycle/rotten
was applied, the PR is closedYou can:
/reopen
/remove-lifecycle rotten
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
@k8s-triage-robot: Closed this PR.
Fixes Issue: #305
Tested: Tested by hand in local test cluster; added test and validated it works with and without annotation,label flags.