search

kubernetes-sigs / hierarchical-namespaces

Home of the Hierarchical Namespace Controller (HNC). Adds hierarchical policies and delegated creation to Kubernetes namespaces for improved in-cluster multitenancy.
Apache License 2.0
607 stars 105 forks source link

Try to make tests pass #367

Closed pjonsson closed 5 months ago

k8s-ci-robot commented 5 months ago

Hi @pjonsson. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
k8s-ci-robot commented 5 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pjonsson Once this PR has been reviewed and has the lgtm label, please assign adrianludwin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/hierarchical-namespaces/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
pjonsson commented 5 months ago

Was hoping this would trigger the hns-postsubmit-test which fails with SIGSEGV on main branch, but:

   [FAILED] in [It] - /home/prow/go/src/sigs.k8s.io/hierarchical-namespaces/test/e2e/namespace_test.go:74 @ 03/12/24 16:18:50.054
  [1710260330] Running:  [kubectl get ns -o custom-columns=:.metadata.name --no-headers=true -l hnc.x-k8s.io/testNamespace=true]
  [1710260330] Running:  [kubectl get ns e2e-test-namespace-b]
  [1710260330] Running:  [kubectl annotate ns e2e-test-namespace-b hnc.x-k8s.io/subnamespace-of-]
  Output (passed):  namespace/e2e-test-namespace-b annotated
  [1710260330] Running:  [kubectl get ns ]
  [1710260330] Running:  [kubectl delete ns e2e-test-namespace-b]
  Output (passed):  namespace "e2e-test-namespace-b" deleted
  << Timeline
  [FAILED] Expected
      <string>: 
  to equal
      <string>: ParentMissing
  In [It] at: /home/prow/go/src/sigs.k8s.io/hierarchical-namespaces/test/e2e/namespace_test.go:74 @ 03/12/24 16:18:50.054

with the dependabot update.

I will let someone who knows the system fix the SIGSEGV, sorry for the noise.