Closed pjonsson closed 5 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: pjonsson Once this PR has been reviewed and has the lgtm label, please assign adrianludwin for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Was hoping this would trigger the hns-postsubmit-test which fails with SIGSEGV
on main branch, but:
[FAILED] in [It] - /home/prow/go/src/sigs.k8s.io/hierarchical-namespaces/test/e2e/namespace_test.go:74 @ 03/12/24 16:18:50.054
[1710260330] Running: [kubectl get ns -o custom-columns=:.metadata.name --no-headers=true -l hnc.x-k8s.io/testNamespace=true]
[1710260330] Running: [kubectl get ns e2e-test-namespace-b]
[1710260330] Running: [kubectl annotate ns e2e-test-namespace-b hnc.x-k8s.io/subnamespace-of-]
Output (passed): namespace/e2e-test-namespace-b annotated
[1710260330] Running: [kubectl get ns ]
[1710260330] Running: [kubectl delete ns e2e-test-namespace-b]
Output (passed): namespace "e2e-test-namespace-b" deleted
<< Timeline
[FAILED] Expected
<string>:
to equal
<string>: ParentMissing
In [It] at: /home/prow/go/src/sigs.k8s.io/hierarchical-namespaces/test/e2e/namespace_test.go:74 @ 03/12/24 16:18:50.054
with the dependabot update.
I will let someone who knows the system fix the SIGSEGV, sorry for the noise.
Hi @pjonsson. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with
/ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.Once the patch is verified, the new status will be reflected by the
ok-to-test
label.I understand the commands that are listed here.