Closed pjonsson closed 5 months ago
Hi @pjonsson. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: pjonsson Once this PR has been reviewed and has the lgtm label, please assign adrianludwin for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Issue seems fixed by #370, so closing this.
I thought this would re-open #367, but Github apparently thinks otherwise.
The hnc-postsubmit-test has been red on the main branch since 14 February.
Cherry-pick the dependabot update of gomega and put a commit on top of that to disable the failing test in hnc-postsubmit-test. Disabling tests is not great, but at least it will be clear if some future change breaks things even more.