search

kubernetes-sigs / hierarchical-namespaces

Home of the Hierarchical Namespace Controller (HNC). Adds hierarchical policies and delegated creation to Kubernetes namespaces for improved in-cluster multitenancy.
Apache License 2.0
607 stars 105 forks source link

[Docs] Add caution about updating helm #384

Open mochizuki875 opened 1 month ago

mochizuki875 commented 1 month ago

What type of PR is this?:

/kind documentation

What this PR does / why we need it:

When attempting to update helm template, we should update /hack/helm_patches/update-helm.sh instead of /charts/hnc/templates/*.yaml. However there are no indication about that and some contributors was confused.(eg. #312, #380) In this PR, I've added caution to contributing doc.

Tested:

none

k8s-ci-robot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mochizuki875 Once this PR has been reviewed and has the lgtm label, please assign rjbez17 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubernetes-sigs/hierarchical-namespaces/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mochizuki875 commented 1 month ago

/retest