Open mochizuki875 opened 1 month ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: mochizuki875 Once this PR has been reviewed and has the lgtm label, please assign rjbez17 for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/retest
What type of PR is this?:
/kind documentation
What this PR does / why we need it:
When attempting to update helm template, we should update
/hack/helm_patches/update-helm.sh
instead of/charts/hnc/templates/*.yaml
. However there are no indication about that and some contributors was confused.(eg. #312, #380) In this PR, I've added caution to contributing doc.Tested:
none