kubernetes-sigs / hydrophone

Hydrophone is a lightweight Kubernetes conformance tests runner
Apache License 2.0
67 stars 31 forks source link

run-e2e script CHECK_DURATION: unbound variable #104

Closed rjsadow closed 9 months ago

rjsadow commented 9 months ago

An issue in our hack/run-e2e.sh script is causing periodic jobs to fail. The variable CHECK_DURATION should be initialized similar to the other variables around https://github.com/kubernetes-sigs/hydrophone/blob/main/hack/run-e2e.sh#L70-L82 or have a default value set on line 54.

hack/run-e2e.sh: line 54: CHECK_DURATION: unbound variable

If anyone wants to take a look at this, please feel free to assign yourself to the issue. And if there are any questions, reach out in this issue or to me on slack at @rjsadow

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/hydrophone-e2e-check/1747715074929201152

rjsadow commented 9 months ago

/good-first-issue

k8s-ci-robot commented 9 months ago

@rjsadow: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubernetes-sigs/hydrophone/issues/104): >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
reetasingh commented 9 months ago

I can look into this

reetasingh commented 9 months ago

/assign

NaveenGokavarapu19 commented 9 months ago

i would like to look at this

NaveenGokavarapu19 commented 9 months ago

/assign

NaveenGokavarapu19 commented 9 months ago

hii @reetasingh can we both look at the issue. If it ok for you