search

kubernetes-sigs / hydrophone

Hydrophone is a lightweight Kubernetes conformance tests runner
Apache License 2.0
65 stars 30 forks source link

Redundant error check in client.PrintE2ELogs() function #123

Closed reetasingh closed 8 months ago

reetasingh commented 8 months ago

The error check on https://github.com/kubernetes-sigs/hydrophone/blob/main/pkg/client/check.go#L63 seems redundant since it will always be nil given that within the for loopa new err variable is initialized everytime https://github.com/kubernetes-sigs/hydrophone/blob/main/pkg/client/check.go#L55

rjsadow commented 8 months ago

I agree, we can remove that block without issue.

rjsadow commented 8 months ago

@reetasingh are you interesting in updating this block?

reetasingh commented 8 months ago

@rjsadow yes, will raise a PR

rjsadow commented 8 months ago

/assign @reetasingh