Currently --parallel gives the impression of setting the concurrency level (thread/goroutine count). This makes sense when looking at the Dockerfile for the conformance tester:
ENV E2E_PARALLEL="1"
However when I grep through the k/k codebase, this env is only used in 2 places:
Since hydrophone does not set a custom command, setting --parallel=7 has no effect.
run_e2e.sh is deprecated and now only a shim to the go-runner, so I guess it would make sense to redefine --parallel to be a boolean. Alternatively maybe it could remain an int and set the --procs (--nodes is an alias for it) flag via E2E_EXTRA_GINKGO_ARGS, like the run_e2e.sh did?
Currently
--parallelgives the impression of setting the concurrency level (thread/goroutine count). This makes sense when looking at the Dockerfile for the conformance tester:However when I grep through the k/k codebase, this env is only used in 2 places:
run_e2e.sh, which is the only place that optionally considers the env to be a number: https://github.com/kubernetes/kubernetes/blob/ec301a5cc76f48cdadc77bcfbd686cf40b124ecf/test/conformance/image/run_e2e.sh#L60-L66Since hydrophone does not set a custom command, setting
--parallel=7has no effect.run_e2e.shis deprecated and now only a shim to the go-runner, so I guess it would make sense to redefine--parallelto be a boolean. Alternatively maybe it could remain an int and set the--procs(--nodesis an alias for it) flag viaE2E_EXTRA_GINKGO_ARGS, like therun_e2e.shdid?