Closed xrstf closed 5 months ago
Hi @xrstf. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
/ok-to-test
/assign @reetasingh @rjsadow
/lgtm /approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: rjsadow, xrstf
The full list of commands accepted by this bot can be found here.
The pull request process is described here
This is a suggestion to how we could handle
--parallel
to control the concurrency in Ginkgo. Importantly, setting--parallel
to a value larger than 1 does not setE2E_PARALLEL=true
, as this would make the go-runner automatically set--p --skip=\[Serial\]
, which would skip a few important test cases.Since we would now already control the
E2E_EXTRA_GINKGO_ARGS
variable, I also made it available on the CLI. This would allow someone to run--parallel --extra-ginkgo-args="--parallel=true --skip=...."
to really only run the parallel tests.It would work like this:
and dramatically speeds up the conformance tests, from ~1h30min to 20min.
I'm not sure if this is the best/correct solution, but it seems to work :-) Maybe the way
--parallel
here does not map to--parallel
in Ginkgo is confusing, maybe it would make more sense to introduce a new flag / rename--parallel
to something like--concurrency=<int>
? Or even directly adapt Ginkgo's--procs
/--nodes
?Fixes #167