k8s-ci-robot
commented
7 months ago Hi @xrstf. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
xmudrii
dims
This code was missing O_TRUNC.
Without it, my first hydrophone run randomly had issues and was dumping a 142MB junit_01.xml, containing lots of pod logs. I then re-ran hydrophone on another cluster where the tests succeeded, but I still seemingly got a 142MB file.
In reality, hydrophone was fetching a 2.5MB file and was only updating/replacing the first 2.5MB of my junit_01.xml file, instead of overwriting it completely.
Adding O_TRUNC would make this more or less equivalent to OpenFile(), except that Create() sets file permissions to 0666 instead of our 0600, which I think is perfectly acceptable. The junit/e2e logs are not secret data that should be kept from other users on the system.