kubernetes-sigs / hydrophone

Hydrophone is a lightweight Kubernetes conformance tests runner
Apache License 2.0
67 stars 31 forks source link

hide spinner on -v <= 2, show test logs in realtime with -v >= 6 #176

Closed xrstf closed 7 months ago

xrstf commented 7 months ago

This PR makes more use of the --verbosity flag.

This would fix #168.

k8s-ci-robot commented 7 months ago

Hi @xrstf. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rjsadow commented 7 months ago

Great idea and addition! /ok-to-test /lgtm /approved /hold Remove hold when tests pass and you're ready to merge.

xrstf commented 7 months ago

/hold cancel

xrstf commented 7 months ago

@rjsadow I think you meant /approve 😀

dims commented 7 months ago

/approve

( casting for @rjsadow :) )

k8s-ci-robot commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/hydrophone/blob/main/OWNERS)~~ [dims] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment