search

kubernetes-sigs / hydrophone

Hydrophone is a lightweight Kubernetes conformance tests runner
Apache License 2.0
67 stars 31 forks source link

Handle errors coming from `viper.BindPFlag` #179

Closed embik closed 6 months ago

embik commented 6 months ago

This is the promised follow up to #170, removing the temporary nolint directive that I put there to make sure we didn't create any merge conflicts. Since the relevant PRs touching cmd/root.go are now merged, this should be safe again.

To avoid writing if err := ...; err != nil { log.Fatal(err) } ten times, I've added a little wrapper. I can undo that and go with the if pattern if that's preferred.

k8s-ci-robot commented 6 months ago

Hi @embik. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
rjsadow commented 6 months ago

/lgtm /approve

embik commented 6 months ago

needed a rebase after #172 merged, should be good to go now @rjsadow. Didn't realise there was a potential conflict still open.

rjsadow commented 6 months ago

/lgtm thanks!

embik commented 6 months ago

Third time's the charm, I hope. I messed up the rebase.

rjsadow commented 6 months ago

/ok-to-test

rjsadow commented 6 months ago

/lgtm /approve

k8s-ci-robot commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik, rjsadow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/hydrophone/blob/main/OWNERS)~~ [rjsadow] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment