kubernetes-sigs / hydrophone

Hydrophone is a lightweight Kubernetes conformance tests runner
Apache License 2.0
67 stars 31 forks source link

feat: SecurityContexts to fullfill PodSecurity policy baseline #218

Closed camaeel closed 1 week ago

camaeel commented 3 weeks ago

SecurityContexts to fullfill PodSecurity policy baseline.

Adds containers securityContext settings.

Fixes: #217

k8s-ci-robot commented 3 weeks ago

Welcome @camaeel!

It looks like this is your first PR to kubernetes-sigs/hydrophone 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/hydrophone has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot commented 3 weeks ago

Hi @camaeel. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rjsadow commented 3 weeks ago

/ok-to-test

camaeel commented 3 weeks ago

e2e test run with kind was successful:

Ginkgo ran 1 suite in 1h48m45.314845655s
Test Suite Passed
2024/10/18 21:01:41 Saving results at /tmp/results
23:01:41 INF Tests finished after 1h48m38s.
23:01:41 INF Downloading e2e.log to /Users/kamil/src/github.com/camaeel/hydrophone/_artifacts/results/e2e.log...
23:01:42 INF Downloading junit_01.xml to /Users/kamil/src/github.com/camaeel/hydrophone/_artifacts/results/junit_01.xml...
23:01:42 INF Waiting for Pod to terminate...
23:01:42 INF Container conformance-container terminated.
23:01:42 INF Deleted ClusterRoleBinding conformance-serviceaccount-role:conformance.
23:01:42 INF Deleted ClusterRole conformance-serviceaccount:conformance.
23:01:42 INF Waiting for Namespace conformance to be deleted.
23:02:20 INF Deleted Namespace conformance.
23:02:20 INF Tests completed successfully.
+ [[ false == \t\r\u\e ]]
+ [[ ! -z '' ]]
camaeel commented 1 week ago

@rjsadow, @dims @reetasingh Hi, any chance for review and approval? Or something is still missing before it can be successfully reviewed?

dims commented 1 week ago

/hold

for a discussion in #k8s-conformance slack - https://kubernetes.slack.com/archives/C78F00H99/p1730754208027609

dims commented 1 week ago

/hold cancel

dims commented 1 week ago

/approve

k8s-ci-robot commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camaeel, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubernetes-sigs/hydrophone/blob/main/OWNERS)~~ [dims] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment